Skip to content

Commit

Permalink
Merge pull request #2161 from inteon/include_error
Browse files Browse the repository at this point in the history
馃尡 Return the error from rest.HTTPClientFor instead of hiding it
  • Loading branch information
k8s-ci-robot committed Jan 31, 2023
2 parents e2dbb0e + e3143ac commit 5db1738
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ func defaultOpts(config *rest.Config, opts Options) (Options, error) {
opts.HTTPClient, err = rest.HTTPClientFor(config)
if err != nil {
logger.Error(err, "Failed to get HTTP client")
return opts, fmt.Errorf("could not create HTTP client from config")
return opts, fmt.Errorf("could not create HTTP client from config: %w", err)
}
}

Expand All @@ -466,7 +466,7 @@ func defaultOpts(config *rest.Config, opts Options) (Options, error) {
opts.Mapper, err = apiutil.NewDiscoveryRESTMapper(config, opts.HTTPClient)
if err != nil {
logger.Error(err, "Failed to get API Group-Resources")
return opts, fmt.Errorf("could not create RESTMapper from config")
return opts, fmt.Errorf("could not create RESTMapper from config: %w", err)
}
}

Expand Down

0 comments on commit 5db1738

Please sign in to comment.