Merge pull request #238 from mengqiy/disable_metrics_by_default

✨ change metrics default to off
kubernetes-sigs · Dec 5, 2018 · 86ad6a3 · 86ad6a3
2 parents 8f98fb7 + f332dbe
commit 86ad6a3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/metrics/listener.go b/pkg/metrics/listener.go
@@ -23,7 +23,9 @@ import (
 
 // DefaultBindAddress sets the default bind address for the metrics
 // listener
-var DefaultBindAddress = ":8080"
+// The metrics is off by default.
+// TODO: Flip the default by changing DefaultBindAddress back to ":8080" in the v0.2.0.
+var DefaultBindAddress = "0"
 
 // NewListener creates a new TCP listener bound to the given address.
 func NewListener(addr string) (net.Listener, error) {