Fix tests after upgrade to prometheus v0.9.0

kubernetes-sigs · Nov 1, 2018 · 9bc6981 · 9bc6981
1 parent b063917
commit 9bc6981
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/internal/controller/controller_test.go b/pkg/internal/controller/controller_test.go
@@ -479,7 +479,9 @@ var _ = Describe("controller", func() {
 
 				var reconcileTime dto.Metric
 				Eventually(func() error {
-					ctrlmetrics.ReconcileTime.WithLabelValues(ctrl.Name).Write(&reconcileTime)
+					histObserver := ctrlmetrics.ReconcileTime.WithLabelValues(ctrl.Name)
+					hist := histObserver.(prometheus.Histogram)
+					hist.Write(&reconcileTime)
 					if reconcileTime.GetHistogram().GetSampleCount() != uint64(1) {
 						return fmt.Errorf("metrics not updated")
 					}

diff --git a/pkg/manager/manager_test.go b/pkg/manager/manager_test.go
@@ -360,7 +360,7 @@ var _ = Describe("manger.Manager", func() {
 					Name: "test_one",
 					Help: "test metric for testing",
 				})
-				one.Set(1)
+				one.Inc()
 				err := metrics.Registry.Register(one)
 				Expect(err).NotTo(HaveOccurred())