-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 IsConvertible should not error on uninitialized struct.
IsConvertible used to use obj.GetObjectKind().GroupVersionKind() to get GVK which will not work if apiVersion and kind fields are not set. Now it uses scheme.ObjectKinds(obj).
- Loading branch information
Mengqi Yu
committed
Jun 28, 2019
1 parent
4c81828
commit 9f5b249
Showing
2 changed files
with
44 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters