Skip to content

Commit

Permalink
Merge pull request #2284 from vincepri/golangcilint152
Browse files Browse the repository at this point in the history
🌱 Update golangci-lint to v1.52.1
  • Loading branch information
k8s-ci-robot committed Apr 20, 2023
2 parents 1c2a7c9 + e301ba3 commit a24b949
Show file tree
Hide file tree
Showing 3 changed files with 124 additions and 98 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.51.1
version: v1.52.1
working-directory: ${{matrix.working-directory}}
32 changes: 29 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,35 @@ linters-settings:
include-go-root: true
packages:
- io/ioutil # https://go.dev/doc/go1.16#ioutil
revive:
rules:
# The following rules are recommended https://github.com/mgechev/revive#recommended-configuration
- name: blank-imports
- name: context-as-argument
- name: context-keys-type
- name: dot-imports
- name: error-return
- name: error-strings
- name: error-naming
- name: exported
- name: if-return
- name: increment-decrement
- name: var-naming
- name: var-declaration
- name: range
- name: receiver-naming
- name: time-naming
- name: unexported-return
- name: indent-error-flow
- name: errorf
- name: superfluous-else
- name: unreachable-code
- name: redefines-builtin-id
#
# Rules in addition to the recommended configuration above.
#
- name: bool-literal-in-expr
- name: constant-logical-expr

issues:
max-same-issues: 0
Expand Down Expand Up @@ -133,9 +162,6 @@ issues:
- linters:
- gosec
text: "G304: Potential file inclusion via variable"
- linters:
- revive
text: "package-comments: should have a package comment"
- linters:
- dupl
path: _test\.go
Expand Down
Loading

0 comments on commit a24b949

Please sign in to comment.