Merge pull request #591 from weters/book-finalizers-590

#590 - Update documentation for Finalizers to return an explicit error
kubernetes-sigs · Feb 5, 2019 · a36c521 · a36c521
2 parents e1b192a + 0f0fc77
commit a36c521
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/docs/book/beyond_basics/using_finalizers.md b/docs/book/beyond_basics/using_finalizers.md
@@ -39,7 +39,7 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
 		if !containsString(instance.ObjectMeta.Finalizers, myFinalizerName) {
 			instance.ObjectMeta.Finalizers = append(instance.ObjectMeta.Finalizers, myFinalizerName)
 			if err := r.Update(context.Background(), instance); err != nil {
-				return reconcile.Result{Requeue: true}, nil
+				return reconcile.Result{}, err
 			}
 		}
 	} else {
@@ -55,7 +55,7 @@ func (r *Reconciler) Reconcile(request reconcile.Request) (reconcile.Result, err
 			// remove our finalizer from the list and update it.
 			instance.ObjectMeta.Finalizers = removeString(instance.ObjectMeta.Finalizers, myFinalizerName)
 			if err := r.Update(context.Background(), instance); err != nil {
-				return reconcile.Result{Requeue: true}, nil
+				return reconcile.Result{}, err
 			}
 		}