Merge pull request #160 from pusher/fix-race

Use read mutex when iterating over informers map
kubernetes-sigs · Sep 25, 2018 · b2824f6 · b2824f6
2 parents d2963e0 + ef53383
commit b2824f6
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/cache/internal/informers_map.go b/pkg/cache/internal/informers_map.go
@@ -127,6 +127,8 @@ func (ip *specificInformersMap) Start(stop <-chan struct{}) {
 
 // HasSyncedFuncs returns all the HasSynced functions for the informers in this map.
 func (ip *specificInformersMap) HasSyncedFuncs() []cache.InformerSynced {
+	ip.mu.RLock()
+	defer ip.mu.RUnlock()
 	syncedFuncs := make([]cache.InformerSynced, 0, len(ip.informersByGVK))
 	for _, informer := range ip.informersByGVK {
 		syncedFuncs = append(syncedFuncs, informer.Informer.HasSynced)