Skip to content

Commit

Permalink
Mark pending tests as pending
Browse files Browse the repository at this point in the history
This marks tests that have a "// TODO: write this" or similar as pending
tests, so that we can keep track of them.
  • Loading branch information
DirectXMan12 committed Dec 4, 2018
1 parent b408f2f commit d583e16
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions pkg/internal/controller/controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,11 +177,11 @@ var _ = Describe("controller", func() {
Expect(ctrl.Watch(src, evthdl)).To(Equal(expected))
})

It("should inject dependencies into the Reconciler", func() {
PIt("should inject dependencies into the Reconciler", func() {
// TODO(community): Write this
})

It("should return an error if there is an error injecting into the Reconciler", func() {
PIt("should return an error if there is an error injecting into the Reconciler", func() {
// TODO(community): Write this
})

Expand Down Expand Up @@ -300,7 +300,7 @@ var _ = Describe("controller", func() {
close(done)
})

It("should forget an item if it is not a Request and continue processing items", func() {
PIt("should forget an item if it is not a Request and continue processing items", func() {
// TODO(community): write this test
})

Expand Down Expand Up @@ -392,19 +392,19 @@ var _ = Describe("controller", func() {
Eventually(func() int { return ctrl.Queue.NumRequeues(request) }).Should(Equal(0))
})

It("should forget the Request if Reconciler is successful", func() {
PIt("should forget the Request if Reconciler is successful", func() {
// TODO(community): write this test
})

It("should return if the queue is shutdown", func() {
PIt("should return if the queue is shutdown", func() {
// TODO(community): write this test
})

It("should wait for informers to be synced before processing items", func() {
PIt("should wait for informers to be synced before processing items", func() {
// TODO(community): write this test
})

It("should create a new go routine for MaxConcurrentReconciles", func() {
PIt("should create a new go routine for MaxConcurrentReconciles", func() {
// TODO(community): write this test
})

Expand Down
2 changes: 1 addition & 1 deletion pkg/source/source_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ var _ = Describe("Source", func() {
})

// TODO(pwittrock): Write this test
Context("for a Foo CRD resource", func() {
PContext("for a Foo CRD resource", func() {
It("should provide Foo Events", func() {

})
Expand Down

0 comments on commit d583e16

Please sign in to comment.