-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Controller: Return error when started more than once
Starting the controller more than once is always wrong. Today, it will result in: * Its active workqueue being re-created, resulting in a data race, breaking the guarantee of "there is at most one worker on a given queue key" and messed-up metrics * Starting double as many workers as configured This PR changes that to instead return an error on all subsequent Start attempts.
- Loading branch information
1 parent
bb54523
commit db22614
Showing
2 changed files
with
15 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters