Skip to content

Commit

Permalink
⚠ fake client: use correct RBAC apiGroup name when deciding if to all…
Browse files Browse the repository at this point in the history
…ow unconditional updates (#2412)

* update fake client rbac group for unconditionalUpdate

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* add old group name back for backward compatibility

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

* drop old rbac group name

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>

---------

Signed-off-by: Jaideep Rao <jaideep.r97@gmail.com>
  • Loading branch information
jaideepr97 committed Aug 4, 2023
1 parent bc27961 commit dbcf380
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/client/fake/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ func allowsUnconditionalUpdate(gvk schema.GroupVersionKind) bool {
case "PodSecurityPolicy":
return true
}
case "rbac":
case "rbac.authorization.k8s.io":
switch gvk.Kind {
case "ClusterRole", "ClusterRoleBinding", "Role", "RoleBinding":
return true
Expand Down

0 comments on commit dbcf380

Please sign in to comment.