-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
- Loading branch information
1 parent
5e5ea56
commit e362644
Showing
3 changed files
with
107 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package finalizer | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
. "github.com/onsi/ginkgo" | ||
. "github.com/onsi/gomega" | ||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"sigs.k8s.io/controller-runtime/pkg/client" | ||
"sigs.k8s.io/controller-runtime/pkg/envtest/printer" | ||
) | ||
|
||
type mockFinalizer struct{} | ||
|
||
func (f mockFinalizer) Finalize(context.Context, client.Object) (needsUpdate bool, err error) { | ||
return true, nil | ||
} | ||
func TestFinalizer(t *testing.T) { | ||
RegisterFailHandler(Fail) | ||
suiteName := "Finalizer Suite" | ||
RunSpecsWithDefaultAndCustomReporters(t, suiteName, []Reporter{printer.NewlineReporter{}, printer.NewProwReporter(suiteName)}) | ||
} | ||
|
||
var _ = Describe("TestFinalizer", func() { | ||
var err error | ||
var pod *corev1.Pod | ||
var finalizers Finalizers | ||
var f mockFinalizer | ||
BeforeEach(func() { | ||
pod = &corev1.Pod{ | ||
ObjectMeta: metav1.ObjectMeta{ | ||
Finalizers: []string{"finalizers.sigs.k8s.io/testfinalizer"}, | ||
}, | ||
} | ||
Expect(pod).NotTo(BeNil()) | ||
|
||
finalizers = NewFinalizers() | ||
Expect(finalizers).NotTo(BeNil()) | ||
|
||
f := mockFinalizer{} | ||
Expect(f).NotTo(BeNil()) | ||
|
||
}) | ||
Describe("Finalizer helper library", func() { | ||
It("Register should successfully register a finalizer", func() { | ||
err = finalizers.Register("finalizers.sigs.k8s.io/testfinalizer", f) | ||
Expect(err).To(BeNil()) | ||
}) | ||
|
||
It("Register should return an error when it is called twice with the same key", func() { | ||
err = finalizers.Register("finalizers.sigs.k8s.io/testfinalizer", f) | ||
Expect(err).To(BeNil()) | ||
|
||
// calling Register again with the same key should return an error | ||
err = finalizers.Register("finalizers.sigs.k8s.io/testfinalizer", f) | ||
Expect(err).NotTo(BeNil()) | ||
Expect(err.Error()).To(ContainSubstring("already registered")) | ||
|
||
}) | ||
|
||
It("Finalize should return no error and indicate false for needsUpdate if a finalizer is not registered", func() { | ||
ret, err := finalizers.Finalize(context.TODO(), pod) | ||
Expect(err).To(BeNil()) | ||
Expect(ret).To(BeFalse()) | ||
}) | ||
|
||
It("Finalize should return no error when deletion timestamp is not nil and the finalizer exists", func() { | ||
now := metav1.Now() | ||
pod.DeletionTimestamp = &now | ||
|
||
err = finalizers.Register("finalizers.sigs.k8s.io/testfinalizer", f) | ||
Expect(err).To(BeNil()) | ||
|
||
_, err := finalizers.Finalize(context.TODO(), pod) | ||
Expect(err).To(BeNil()) | ||
}) | ||
|
||
It("Finalize should return no error when deletion timestamp is nil and finalizer does not exist", func() { | ||
err = finalizers.Register("finalizers.sigs.k8s.io/testfinalizer", f) | ||
Expect(err).To(BeNil()) | ||
|
||
pod.DeletionTimestamp = nil | ||
pod.Finalizers = []string{} | ||
|
||
needsUpdate, err := finalizers.Finalize(context.TODO(), pod) | ||
Expect(err).To(BeNil()) | ||
Expect(needsUpdate).To(BeTrue()) | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters