⚠️ Remove error log in internal controller, set V=5 for Info

Signed-off-by: Vince Prignano <vincepri@vmware.com>
kubernetes-sigs · Aug 4, 2020 · e4e8977 · e4e8977
1 parent 4ffd908
commit e4e8977
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/pkg/internal/controller/controller.go b/pkg/internal/controller/controller.go
@@ -234,7 +234,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
 	// resource to be synced.
 	if result, err := c.Do.Reconcile(req); err != nil {
 		c.Queue.AddRateLimited(req)
-		log.Error(err, "Reconciler error")
 		ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc()
 		ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "error").Inc()
 		return false
@@ -257,9 +256,7 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
 	// get queued again until another change happens.
 	c.Queue.Forget(obj)
 
-	// TODO(directxman12): What does 1 mean?  Do we want level constants?  Do we want levels at all?
-	log.V(1).Info("Successfully Reconciled")
-
+	log.V(5).Info("Successfully Reconciled")
 	ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "success").Inc()
 	// Return true, don't take a break
 	return true