-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #445 from droot/bugfix/go-version-check-fix
improved Go version check
- Loading branch information
Showing
2 changed files
with
105 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/* | ||
Copyright 2018 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package main | ||
|
||
import "testing" | ||
|
||
func TestCheckGoVersion(t *testing.T) { | ||
|
||
tests := []struct { | ||
ver string | ||
isInvalid bool | ||
}{ | ||
{"go1.8", true}, | ||
{"go1.9", true}, | ||
{"go1.10", false}, | ||
{"go1.10rc", false}, | ||
{"go1.10.1", false}, | ||
{"go1.11rc2", false}, | ||
} | ||
|
||
for _, test := range tests { | ||
err := checkGoVersion(test.ver) | ||
if err != nil { | ||
// go error, but the version isn't invalid | ||
if !test.isInvalid { | ||
t.Errorf("Go version check failed valid version '%s' with error '%s'", test.ver, err) | ||
} | ||
} else { | ||
// got no error, but the version is invalid | ||
if test.isInvalid { | ||
t.Errorf("version '%s' is invalid, but got no error", test.ver) | ||
} | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters