Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface warnings sent by apiserver via client-go #1150

Closed
joelanford opened this issue Sep 4, 2020 · 11 comments · Fixed by #1468
Closed

Surface warnings sent by apiserver via client-go #1150

joelanford opened this issue Sep 4, 2020 · 11 comments · Fixed by #1468
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone

Comments

@joelanford
Copy link
Member

We should look into surfacing warnings sent in responses by 1.19+ API servers.

Examples of these warnings include:

  • Use of deprecated core APIs
  • Use of deprecated CRD-defined APIs
  • Warnings returned by admission webhooks

See https://kubernetes.io/blog/2020/09/03/warnings/ for details.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 2, 2021
@camilamacedo86
Copy link
Member

Hi @vincepri,

Should not it be prioritized for the next milestone since soon we will be bumping the k8s api that will no longer supported the deprecated ones?

@vincepri
Copy link
Member

Possibly yeah

@vincepri
Copy link
Member

/milestone v0.9.x
/help
/remove-lifecycle reotten

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.9.x
/help
/remove-lifecycle reotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.9.x milestone Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 26, 2021
@vincepri
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 26, 2021
@palnabarun
Copy link
Member

/assign @MadhavJivrajani

@k8s-ci-robot
Copy link
Contributor

@palnabarun: GitHub didn't allow me to assign the following users: MadhavJivrajani.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @MadhavJivrajani

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MadhavJivrajani
Copy link
Contributor

Hi! I'd like to take this up 😄

/assign

@MadhavJivrajani
Copy link
Contributor

MadhavJivrajani commented Mar 30, 2021

Hi! After going through the linked blog post and the related KEP, this is what I thought of implementing and I was hoping to get some feedback on the same:

  • In pkg/client/client.go, a new default warning handler is set as mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants