use go-logr context functions

[pohly]

go-logr 0.3.0 added support for storing and retrieving a logger in a context: https://github.com/go-logr/logr/blob/4fa77cb7175ca349567983fd9cc9fd94462f41fa/logr.go#L197-L222

It would be good to implement

controller-runtime/pkg/log/log.go

Lines 56 to 73 in f3831c2

	// FromContext returns a logger with predefined values from a context.Context.
	func FromContext(ctx context.Context, keysAndValues ...interface{}) logr.Logger {
	var log logr.Logger = Log
	if ctx != nil {
	if lv := ctx.Value(contextKey); lv != nil {
	log = lv.(logr.Logger)
	}
	}
	return log.WithValues(keysAndValues...)
	}
	// IntoContext takes a context and sets the logger as one of its keys.
	// Use FromContext function to retrieve the logger.
	func IntoContext(ctx context.Context, log logr.Logger) context.Context {
	return context.WithValue(ctx, contextKey, log)
	}

as wrapper around those functions because then code using the controller-runtime methods and code using go-logr directly become interoperable.

As it stands now, the loggers are different because the context keys are different.

[alvaroaleman]

Sounds like a good idea
/good-first-issue

[k8s-ci-robot]

@alvaroaleman:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Sounds like a good idea
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arghya88]

/assign