-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of controller-runtime calls flag for "kubeconfig" #1396
Comments
Addition: the same thing happens when importing |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/kind feature |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
FYI: I created following PR: #1999 |
Should we close this issue now that #1999 has been merged? Or should we keep this issue open until the init function is removed completely (if this is desired at all)? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Sorry for the late reply. I'm not sure if we want to drop the init function. Pro:
Con:
On the other hand, I think almost all controller are just run inside of a Pod and barely anyone is using a --kubeconfig command line flag. IIRC component-base/logs also dropped the implicit registering of flags. So I'm slightly in favor of getting rid of the implicit flag registration (after whatever deprecation period / release notes it is appropriate) @alvaroaleman @vincepri WDYT? |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi there :-),
we are consuming
cluster-api-provider-openstack
which importskubernetes-sigs/controller-runtime
.Because alias.go is importing
sigs.k8s.io/controller-runtime/pkg/client/config
it always defines the "kubeconfig" flag which then conflicts with other places where the same flag is getting defined. (e.g. inside kubernetes' e2e test framework https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/test_context.go#L321)Of course we are able to workaround it by not directly using the functions via
alias.go
but I think this is against the reasons why it does exist?One alternative would be to define a
Christian Schlotter , Daimler TSS GmbH, ImprintRegisterFlag
function instead of defining the flag viafunc init() {...}
, however this leads to a breaking change.The text was updated successfully, but these errors were encountered: