Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetOption in client get call #1915

Closed
l1b0k opened this issue May 27, 2022 · 2 comments · Fixed by #1917
Closed

Add GetOption in client get call #1915

l1b0k opened this issue May 27, 2022 · 2 comments · Fixed by #1917
Assignees

Comments

@l1b0k
Copy link

l1b0k commented May 27, 2022

Add GetOption so client can work with metav1.GetOptions

@FillZpp
Copy link
Contributor

FillZpp commented May 30, 2022

Discussion from slack:

Why do you need ResourceVersion="0" for your get operation? It returns object with ANY resourceVersion according to the doc https://kubernetes.io/docs/reference/using-api/api-concepts/#semantics-for-get-and-list

resourceVersion="0" return a cached result , optimize performance at large scale. resourceVersion="" always get latest result.

That would be a difference. But mostly we use resourceVersion="0" for list to avoid reading too many objects from etcd. Do you have a large number of get operation that is really necessary to set the flag?

Sure, i have opened an issue #1915 to discuss this.
In short , i have daemonSet agent and controller , prefer to use single kubernetes client to simplify the code ,also performance is our concern.

@FillZpp
Copy link
Contributor

FillZpp commented May 30, 2022

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants