Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve metrics for non-leader pods #196

Closed
JoelSpeed opened this issue Nov 3, 2018 · 1 comment
Closed

Serve metrics for non-leader pods #196

JoelSpeed opened this issue Nov 3, 2018 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@JoelSpeed
Copy link
Contributor

When using leader election, metrics aren't served and so the non-leader pods are shown as "Down" by prometheus when it scrapes the pod.

Raised originally in #132 (comment)

To fix this, controller-runtime should start serving metrics while waiting to acquire leader status.
We need to make sure however that it doesn't serve metrics that are false, prometheus should pick up no time series from it and just connect, read and get a basically empty document.
@JoelSpeed JoelSpeed mentioned this issue Nov 3, 2018
Merged
@DirectXMan12
Copy link
Contributor

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 5, 2018
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@droot
Merge pull request #196 from anfernee/fix-test
833dc0f 
Fix test.sh and enable test on OSX
@clyang82 clyang82 mentioned this issue Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DirectXMan12 @JoelSpeed @k8s-ci-robot