Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky metrics test #199

Closed
DirectXMan12 opened this issue Nov 5, 2018 · 1 comment · Fixed by #200
Closed

Flaky metrics test #199

DirectXMan12 opened this issue Nov 5, 2018 · 1 comment · Fixed by #200
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@DirectXMan12
Copy link
Contributor

e.g. https://travis-ci.org/kubernetes-sigs/controller-runtime/jobs/450256058#L617

Currently holding up a couple of PRs (e.g. #193, #197). I'd guess it's a flake, since it appears in different go versions.

@JoelSpeed @droot FYI
@DirectXMan12
Copy link
Contributor Author

DirectXMan12 commented Nov 5, 2018 •
edited
Loading

/priority critical-urgent

(this is causing test issues)

/kind bug

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. labels Nov 5, 2018
@JoelSpeed JoelSpeed mentioned this issue Nov 6, 2018
Merged
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@droot
Merge pull request #199 from lichuqiang/image_rollback
4507935 
Add truncate options when opening files to overwrite contents in existing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor metrics tests pusher/controller-runtime
2 participants
@DirectXMan12 @k8s-ci-robot