Unstructured client's List does not propagate GVK to items

[hiddeco]

The List method does prepare the gvk to an "unsafe guess that doen't actually work, but matches ~99% of the cases out there", but this is never actually being put to use:

controller-runtime/pkg/client/unstructured_client.go

Lines 207 to 208 in 10a0272

	gvk := u.GroupVersionKind()
	gvk.Kind = strings.TrimSuffix(gvk.Kind, "List")

Which does seem to be a left-over from changes in #812, which also mentions:

[...] feels like I probably need to fix up some GVKs somewhere in the lists...

However, given that for metav1.PartialObjectMetadataList the GVK is later restored in the wrapping client:

controller-runtime/pkg/client/client.go

Lines 372 to 383 in 4fd4f6e

	// Restore the GVK for each item in the list.
	itemGVK := schema.GroupVersionKind{
	Group: gvk.Group,
	Version: gvk.Version,
	// TODO: this is producing unsafe guesses that don't actually work,
	// but it matches ~99% of the cases out there.
	Kind: strings.TrimSuffix(gvk.Kind, "List"),
	}
	for i := range x.Items {
	item := &x.Items[i]
	item.SetGroupVersionKind(itemGVK)
	}

I am wondering if the same approach could be taken for the unstructured.UnstructuredList, as this would ease consumption in ~99% of the cases. If agreed on, I am happy to submit a PR.

[vincepri]

Probably an oversight that needs to be fixed, yes. Could we add a few test cases though to capture the error first? It'd be good to have tests for a custom resource and core one

[hiddeco]

Not a problem, if you provide a bit more information about the precise error (trigger) you would like to see captured.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.