Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow restricting the Cache's ListWatch to a set of namespaces #218

Closed
hasbro17 opened this issue Nov 20, 2018 · 3 comments
Closed

Allow restricting the Cache's ListWatch to a set of namespaces #218

hasbro17 opened this issue Nov 20, 2018 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@hasbro17
Copy link
Contributor

As a follow up to #124 the manager should allow restricting the cache to a set of namespaces.

Watching on all namespaces and filtering the events(via predicates) to the desired namespaces is the only way to watch a set of namespaces currently.
The problem with that is it still requires a ClusterRoleBinding, whereas the user might want to grant more fine grained permissions of a ClusterRole with multiple RoleBindings(referring to the manager's service account).

Proposed Fix:
As discussed in #124 (comment) we can use a MultiListWatcher in the cache if the manager is passed a set of namespaces.
@DirectXMan12
Copy link
Contributor

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 28, 2018
This was referenced Feb 13, 2019
Closed
Closed
@shawn-hurley
Copy link

@DirectXMan12 I think this is closed by #267

@DirectXMan12
Copy link
Contributor

yep!

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@pwittrock
Link project deps from hack/imports.go
f1142fd 
Fixes #218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DirectXMan12 @shawn-hurley @hasbro17 @k8s-ci-robot