Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding Values in Manager #226

Closed
shawn-hurley opened this issue Nov 29, 2018 · 1 comment · Fixed by #227
Closed

Overriding Values in Manager #226

shawn-hurley opened this issue Nov 29, 2018 · 1 comment · Fixed by #227
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@shawn-hurley
Copy link

As a user, I would like the ability to specify the cache and client that the manager injects into other objects.

I am proposing that the manager options expose the new functions for client and cache.

NewCache  func(config *rest.Config, opts cache.Options) (cache.Cache, error)
NewClient func(config *rest.Config, options client.Options) (client.Client, error)

The defaults will stay the same, this will allow users to change the client.

I also believe that their should be a new method NewDelegatingClient func(cache cache.Cache, client client.Client) (client.Client, error) that will allow a user to define which delegating client they would like to use. The default should be the same as it is today IMO.

/cc @DirectXMan12 @droot @ironcladlou
@shawn-hurley
Copy link
Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2018
shawn-hurley pushed a commit to shawn-hurley/controller-runtime that referenced this issue Nov 29, 2018
✨ Allow user to define how create managed objects
c71ff3f 
* Allow the user to specify in the options how to create the client,
cache, and how to construct the delegating client.

fixes kubernetes-sigs#226
@shawn-hurley shawn-hurley mentioned this issue Nov 29, 2018
Merged
shawn-hurley pushed a commit to shawn-hurley/controller-runtime that referenced this issue Dec 5, 2018
✨ Allow user to define how create managed objects
cc79493 
* Allow the user to specify in the options how to create the client,
cache, and how to construct the delegating client.

fixes kubernetes-sigs#226
shawn-hurley pushed a commit to shawn-hurley/controller-runtime that referenced this issue Dec 6, 2018
✨ Allow user to define how create managed objects
8fba660 
* Allow the user to specify in the options how to create the client,
cache, and how to construct the delegating client.

fixes kubernetes-sigs#226
droot pushed a commit to droot/controller-runtime that referenced this issue Jan 24, 2019
@droot
✨ Allow user to define how create managed objects
39a4e12 
* Allow the user to specify in the options how to create the client,
cache, and how to construct the delegating client.

fixes kubernetes-sigs#226
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@Liujingfang1
Merge pull request #226 from Liujingfang1/refactor
6fd5269 
Move the e2e test library and existing projects to test folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Allow user to define how create managed objects shawn-hurley/controller-runtime
2 participants
@shawn-hurley @k8s-ci-robot