Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport webhook.Server TLSOptions to v0.11 and v0.12? #2353

Closed
nathanperkins opened this issue May 26, 2023 · 5 comments
Closed

Backport webhook.Server TLSOptions to v0.11 and v0.12? #2353

nathanperkins opened this issue May 26, 2023 · 5 comments
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@nathanperkins
Copy link

nathanperkins commented May 26, 2023

TLSOptions were added to webhook.Server in v0.13: 187187e

We need them to mitigate some security issues with the TLS configuration, but we don't want to bump controller-runtime minor versions in our older controller releases which are in maintenance for security fixes only.

Would you accept PRs to cherry pick these to v0.11 and v0.12 and cut patch releases?

@nathanperkins
Copy link
Author

nathanperkins commented May 26, 2023

@vincepri opened #2356, thank you!

Also, he mentioned that it is already in v0.12: 54d6a15

@troy0820
Copy link
Member

troy0820 commented Sep 6, 2023

/kind support
@nathanperkins has this issue been resolved with the PR linked above?

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Sep 6, 2023
@nathanperkins
Copy link
Author

nathanperkins commented Sep 6, 2023 via email

@sbueringer
Copy link
Member

Thx for the confirmation

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Thx for the confirmation

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

No branches or pull requests

4 participants