Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicRESTMapper does not return No{Kind,Resource}MatchError for non-present API groups #2424

Closed
timebertt opened this issue Jul 26, 2023 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@timebertt
Copy link
Contributor

timebertt commented Jul 26, 2023

When calling RESTMapping() and friends for an API Group/GroupVersion that is not present in the system (e.g., CRDs not yet installed), a RESTMapper should return No{Kind,Resource}MatchError.

However, with v0.15.0, the new DynamicRESTMapper returns ErrGroupDiscoveryFailed instead, e.g.

failed to get API group resources: unable to retrieve the complete list of server APIs: some.group/v1: the server could not find the requested resource

A consequence of this behavior is that managers will crash if they register controllers for resources that will only be registered during runtime. This was supported previously with the old DynamicRESTMapper implementation before v0.15.0.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 26, 2023
@timebertt
Copy link
Contributor Author

/assign

@troy0820
Copy link
Member

troy0820 commented Jan 4, 2024

Is this issue still necessary? I see that this PR #2425 is closed but the above PR that was merged took changes from that PR and applied it.
@timebertt

@timebertt
Copy link
Contributor Author

timebertt commented Jan 5, 2024

Yes, we can close this one!
/close

@k8s-ci-robot
Copy link
Contributor

@timebertt: Closing this issue.

In response to this:

Yes!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants