Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document what metrics are registered in godoc #262

Closed
mengqiy opened this issue Dec 19, 2018 · 4 comments · Fixed by #811
Closed

Document what metrics are registered in godoc #262

mengqiy opened this issue Dec 19, 2018 · 4 comments · Fixed by #811
Assignees
@djzager
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.5.x

Comments

@mengqiy
Copy link
Member

mengqiy commented Dec 19, 2018

From #234 (comment)
@DirectXMan12
Copy link
Contributor

/kind documentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 21, 2018
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2019
@mengqiy mengqiy added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels May 28, 2019
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 4, 2019
@kubernetes-sigs kubernetes-sigs deleted a comment from fejta-bot Jun 4, 2019
@vincepri vincepri added this to the v0.5.x milestone Feb 20, 2020
@vincepri
Copy link
Member

grep in our codebase to find the metrics we expose and document them

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

grep in our codebase to find the metrics we expose and document them

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 20, 2020
@vincepri vincepri removed good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Feb 20, 2020
@djzager
Copy link
Contributor

djzager commented Feb 20, 2020

/assign

@djzager djzager mentioned this issue Feb 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djzager djzager

Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging a pull request may close this issue.

📖 document exposed metrics djzager/controller-runtime
5 participants
@DirectXMan12 @djzager @mengqiy @vincepri @k8s-ci-robot