Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect interface assertions in example/mutatingwebhook.go #266

Closed
perryao opened this issue Dec 27, 2018 · 2 comments
Closed

Incorrect interface assertions in example/mutatingwebhook.go #266

perryao opened this issue Dec 27, 2018 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@perryao
Copy link
Contributor

perryao commented Dec 27, 2018

I believe here and here need to be updated to assert podAnnotator's conformance to inject.Client and inject.Decoder.

example/validatingWebhook.go already does the interface assertions for podValidator.

I can submit the PR you agree this needs done.
@perryao perryao changed the title Incorrect Interface Assert in example/mutatingwebhook.go Incorrect interface assertions in example/mutatingwebhook.go Dec 27, 2018
@DirectXMan12
Copy link
Contributor

yep, please do update that. Good catch :-)

@DirectXMan12
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2019
@perryao perryao mentioned this issue Jan 5, 2019
Merged
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #266 from perotinus/removectlr
d0dc250 
Remove ./pkg/controller from docs/gen search paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DirectXMan12 @perryao @k8s-ci-robot