Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook server should work when no webhook is registered under the server #283

Closed
mengqiy opened this issue Jan 8, 2019 · 0 comments · Fixed by #288
Closed

webhook server should work when no webhook is registered under the server #283

mengqiy opened this issue Jan 8, 2019 · 0 comments · Fixed by #288
Assignees
@mengqiy

Comments

@mengqiy
Copy link
Member

mengqiy commented Jan 8, 2019

Currently, when there are no webhooks registered under the webhook server, the web server will not generate serving cert which will result it failing to come up.
This was discovered by @pwittrock when trying to simplify the example.
@mengqiy mengqiy self-assigned this Jan 8, 2019
@mengqiy mengqiy mentioned this issue Jan 9, 2019
Merged
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #283 from surbas/patch-1
b12cdd0 
Change blockquotes to code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengqiy mengqiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 gen cert for the server even there are no webhooks mengqiy/controller-runtime
1 participant
@mengqiy