Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook: Need more injection Interface in webhook server #309

Closed
kdada opened this issue Jan 25, 2019 · 3 comments
Closed

Webhook: Need more injection Interface in webhook server #309

kdada opened this issue Jan 25, 2019 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@kdada
Copy link
Contributor

kdada commented Jan 25, 2019 •
edited
Loading

Webhook server only implements inject.Client and inject.Decoder. I think the server should implement all of injection interfaces. Then I can use these interfaces in my webhooks.
@DirectXMan12
Copy link
Contributor

yep, noticed this bug when trying to reword dep injection. the webhook dep injection code is currently wrong -- it should call injectfields in children, and only implement specific injectors for dependencies it needs.

cc @mengqiy

/kind bug
/priority important-soon
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

yep, noticed this bug when trying to reword dep injection. the webhook dep injection code is currently wrong -- it should call injectfields in children, and only implement specific injectors for dependencies it needs.

cc @mengqiy

/kind bug
/priority important-soon
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 29, 2019
@mengqiy mengqiy assigned mengqiy and unassigned mengqiy Feb 4, 2019
@mengqiy mengqiy mentioned this issue Feb 4, 2019
Closed
@DirectXMan12
Copy link
Contributor

this is closed by #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix webhook injector mengqiy/controller-runtime
4 participants
@DirectXMan12 @mengqiy @kdada @k8s-ci-robot