NewFakeClientWithScheme dies silently

[michaelgugino]

Current master commit:

controller-runtime/pkg/client/fake/client.go

Line 65 in 45d6520

log.Error(err, "failed to add object to fake client", "object", obj)

This line does not result in actual logging in my case, just results (confusingly) in a call to os.Exit(1).

Simple test case (replace clusterautoscaler with a suitable object that is not part of default scheme):

package clusterautoscaler

import (
	"testing"
	fakeclient "sigs.k8s.io/controller-runtime/pkg/client/fake"
	"k8s.io/apimachinery/pkg/runtime"
)

func TestAvailableAndUpdatedCheck2(t *testing.T) {
	tscheme := runtime.NewScheme()
	// With the following commented, we fail silently.
	//apis.AddToScheme(tscheme)
	ca := NewClusterAutoscaler()
	_ = fakeclient.NewFakeClientWithScheme(tscheme, ca)
}

[michaelgugino]

/kind bug

[DirectXMan12]

a) that should probably be a panic, not a log-then-exit. I suspect it was an incorrectly replaced pattern from our purge of fatalf (which doesn't existing in logr).

b) you should generally set up logging in TestMain, BeforeSuite, each test, or what have you (by calling "pkg/log".SetLogger).

[DirectXMan12]

/good-first-issue

/priority backlog

[k8s-ci-robot]

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

/priority backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[anthonyho007]

@DirectXMan12 Can i work on this issue ?

[DirectXMan12]

go ahead. Can't officially assign unless you're an org member, but consider it assigned :-)

/assign @anthonyho007

[k8s-ci-robot]

@DirectXMan12: GitHub didn't allow me to assign the following users: anthonyho007.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

go ahead. Can't officially assign unless you're an org member, but consider it assigned :-)

/assign @anthonyho007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[DirectXMan12]

close as per above PRs