Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specificInformersMap Get may accidentally return an unynced informer #370

Closed
nvachhar opened this issue Mar 22, 2019 · 4 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@nvachhar
Copy link

If specificInformersMap is already started, a call to Get that doesn't find a particular GVK will create the corresponding Informer, add it to the map, and then wait for it to sync. Therefore the caller will get a synced Informer. However, if there is a concurrent caller to Get for the same GVK, it will find the Informer in the map and return it without waiting for it to sync. Therefore the concurrent caller will get an unsynced informer.

@nvachhar
Copy link
Author

I forgot to mention, I have a patch to fix the problem. Just posting the issue to ensure others agree with the problem's existence.

@DirectXMan12
Copy link
Contributor

go ahead and submit the PR to fix it, please

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 25, 2019
@adohe-zz
Copy link

/close

@k8s-ci-robot
Copy link
Contributor

@adohe: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants