Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook server should reload certs on change #390

Closed
vincepri opened this issue Apr 10, 2019 · 5 comments · Fixed by #421
Closed

Webhook server should reload certs on change #390

vincepri opened this issue Apr 10, 2019 · 5 comments · Fixed by #421
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@vincepri
Copy link
Member

Opening this issue to track this TODO. Currently the certificates are only loaded on server creation, there should be some logic to watch the directory and update the tls configuration appropriately.
@vincepri
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 10, 2019
@DirectXMan12
Copy link
Contributor

/priority import-longterm

@DirectXMan12
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@DirectXMan12:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 11, 2019
@anthonyho007 anthonyho007 mentioned this issue Apr 12, 2019
Closed
@bison bison mentioned this issue May 13, 2019
Merged
@bison
Copy link
Contributor

bison commented May 14, 2019

Would love to get some feedback on #421 if anyone has some time. Seems to work for me.

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #390 from mengqiy/update_vendor
f954dc7 
pick up latest controller-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ webhook: Handle TLS certificate rotation
4 participants
@DirectXMan12 @bison @vincepri @k8s-ci-robot