Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission response codes are incorrect #407

Closed
liggitt opened this issue Apr 24, 2019 · 5 comments
Closed

Admission response codes are incorrect #407

liggitt opened this issue Apr 24, 2019 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@liggitt
Copy link

liggitt commented Apr 24, 2019 •
edited
Loading

controller-runtime/pkg/webhook/admission/webhook.go

Line 72 in 856708d

if r.Result.Code == 0 {
is setting status code to 200 even when the response is rejecting a request.

The review.response.status.code should be >= 400 if response.Allowed == false (if response.Allowed == true, the review.response.status is ignored)

xref kubernetes/kubernetes#76984 (comment)
xref open-policy-agent/gatekeeper#97
xref kubernetes/kubernetes#77022
@liggitt
Copy link
Author

liggitt commented Apr 24, 2019

cc @maxsmythe @DirectXMan12

@DirectXMan12
Copy link
Contributor

/kind bug
/priority critical-urgent

@mengqiy

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels May 4, 2019
@mengqiy
Copy link
Member

mengqiy commented May 6, 2019

#400 is the fix and waiting to be merged.

@adohe-zz
Copy link

/close

@k8s-ci-robot
Copy link
Contributor

@adohe: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
Merge pull request #407 from pwittrock/book
f76fb77 
Update GitBook public folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DirectXMan12 @liggitt @adohe-zz @mengqiy @k8s-ci-robot