Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requeue Overhaul Tracking #417

Closed
1 of 3 tasks
DirectXMan12 opened this issue May 8, 2019 · 4 comments
Closed
1 of 3 tasks

Requeue Overhaul Tracking #417

DirectXMan12 opened this issue May 8, 2019 · 4 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented May 8, 2019 •
edited
Loading

We need to rework our requeue handling. Namely:

  • RequeueAfter should never consider backoff (🐛 Reset Failure count for reconcile loops using RequestAfter #396), unless combined with an error
  • Requeue should maybe have an escape hatch to ignore backoff, but you probably want backoff
  • Requeue-on-error should probably ignore "non-transient" errors (e.g. notfound from cache), but determining non-transience is tricky (e.g. notfound is always non-transient from cached data, but may be transient from live data, so this might require x/errors)

Ref #377
@negz negz mentioned this issue Jun 11, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2019
@DirectXMan12
Copy link
Contributor Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 9, 2019
@negz negz mentioned this issue Oct 7, 2019
Closed
DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
@k8s-ci-robot
Merge pull request #417 from droot/bugfix/pick-up-controller-tests-ra…
0f8f2d8 
…ce-fixes

updated the controller-tools pkg under vendor dir
@vincepri
Copy link
Member

Closing in favor of #617

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

Closing in favor of #617

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DirectXMan12 @vincepri @k8s-ci-robot @fejta-bot