controller_runtime_reconcile_time_seconds includes queue wait time

[enisoc]

This metric currently includes the time spent waiting for an item to be available in the queue (while c.Queue.Get() is blocking):

controller-runtime/pkg/internal/controller/controller.go

Lines 176 to 182 in 12d9858

	// Update metrics after processing each item
	reconcileStartTS := time.Now()
	defer func() {
	c.updateMetrics(time.Now().Sub(reconcileStartTS))
	}()
	obj, shutdown := c.Queue.Get()

It would be more useful if it measured only the time spent doing reconciliation after an item is returned by the queue.

[droot]

It would be more useful if it measured only the time spent doing reconciliation after an item is returned by the queue.

Agree. Labeling this as a bug.