"non-exact field matches are not supported by the cache" when using fieldSelector with not exact fields

[sarjeet2013]

I am getting the following error when trying to get list of pods with their state filetered with fieldSelector.

"error":"non-exact field matches are not supported by the cache"

Here is the sample code:

fieldSelector, err := fields.ParseSelector("spec.nodeName=" + nodeName + ",status.phase!=" + string(corev1.PodSucceeded) + ",status.phase!=" + string(corev1.PodFailed))
activePodsList := &corev1.PodList{}
listOptions := &client.ListOptions{FieldSelector: fieldSelector}
if err := r.List(context.TODO(), listOptions, activePodsList); err != nil {
  return reconcile.Result{}, err
}

This look like a current limitation and not supported. See https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/cache/internal/cache_reader.go#L99

[DirectXMan12]

it's unclear to me how we'd support this w/o becoming fairly complicated.

/kind feature
/priority backlog

[lawrencegripper]

In case anyone else lands here from KubeBuilder and wants an workaround I was able to create a client instance without caching using the mgr in the autogen'd main.go like this:

directClient, err := client.New(mgr.GetConfig(), client.Options{Scheme: mgr.GetScheme(), Mapper: mgr.GetRESTMapper()})
if err != nil {
	panic(err)
}

[shawn-hurley]

Another option is to use the mgr.GetReader() which will allow you to hit the API server directly with a reader interface.

[vincepri]

/kind design
/priority awaiting-more-evidence

[maplain]

figured out another approach:

1. use client.MatchingFields;
2. customize the IndexField to make it return a value that is parameterized by multiple fields

eg:

m := client.MatchingFields{
  key: getValue(obj)
}

mgr.GetFieldIndexer().IndexField(obj, key, func(xx) []string{
   return []string{getValue(obj)}
})

func getValue(obj) string {
   return obj.Spec.A + "," + obj.Spec.B + "," + obj.Spec.C
}

Client.List(xx, xxx, m)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kscharm]

I am getting the following error when trying to get list of pods with their state filetered with fieldSelector.

"error":"non-exact field matches are not supported by the cache"

Here is the sample code:

fieldSelector, err := fields.ParseSelector("spec.nodeName=" + nodeName + ",status.phase!=" + string(corev1.PodSucceeded) + ",status.phase!=" + string(corev1.PodFailed))
activePodsList := &corev1.PodList{}
listOptions := &client.ListOptions{FieldSelector: fieldSelector}
if err := r.List(context.TODO(), listOptions, activePodsList); err != nil {
  return reconcile.Result{}, err
}

This look like a current limitation and not supported. See https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/cache/internal/cache_reader.go#L99

@sarjeet2013 I'm trying to do the same thing you are here (same field selector). Were you able to find a workaround? I have tried the suggestions in the comments, but I think I am going to have to directly hit the API to get this to work. It seems that fields selectors with multiple fields simply do not work. I have added the proper field indexers to my manager:

nodeNameIndexFunc := func(obj client.Object) []string {
	return []string{obj.(*v1.Pod).Spec.NodeName}
}

if err = mgr.GetFieldIndexer().IndexField(context.Background(), &v1.Pod{}, "spec.nodeName", nodeNameIndexFunc); err != nil {
	glog.Fatalf("unable to set up field indexer for spec.nodeName: %v", err)
}

phaseIndexFunc := func(obj client.Object) []string {
	return []string{string(obj.(*v1.Pod).Status.Phase)}
}

if err = mgr.GetFieldIndexer().IndexField(context.Background(), &v1.Pod{}, "status.phase", phaseIndexFunc); err != nil {
	glog.Fatalf("unable to set up field indexer for status.phase: %v", err)
}

And I still face the same error as you: non-exact field matches are not supported by the cache

[kscharm]

/reopen

[k8s-ci-robot]

@kscharm: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JohnNiang]

Exactly caused by Line#192:

controller-runtime/pkg/cache/internal/cache_reader.go

Lines 190 to 200 in 386c2b5

	func requiresExactMatch(sel fields.Selector) (field, val string, required bool) {
	reqs := sel.Requirements()
	if len(reqs) != 1 {
	return "", "", false
	}
	req := reqs[0]
	if req.Operator != selection.Equals && req.Operator != selection.DoubleEquals {
	return "", "", false
	}
	return req.Field, req.Value, true
	}

And a TODO is here Line#117:

controller-runtime/pkg/cache/internal/cache_reader.go

Lines 108 to 126 in 386c2b5

	func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...client.ListOption) error {
	var objs []interface{}
	var err error
	listOpts := client.ListOptions{}
	listOpts.ApplyOptions(opts)
	switch {
	case listOpts.FieldSelector != nil:
	// TODO(directxman12): support more complicated field selectors by
	// combining multiple indices, GetIndexers, etc
	field, val, requiresExact := requiresExactMatch(listOpts.FieldSelector)
	if !requiresExact {
	return fmt.Errorf("non-exact field matches are not supported by the cache")
	}
	// list all objects by the field selector. If this is namespaced and we have one, ask for the
	// namespaced index key. Otherwise, ask for the non-namespaced variant by using the fake "all namespaces"
	// namespace.
	objs, err = c.indexer.ByIndex(FieldIndexName(field), KeyToNamespacedKey(listOpts.Namespace, val))