-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
event.DeleteEvent struct's "DeleteStateUnknown" field is never written #654
Comments
can we get some context from k/k? I don't remember what our intention was with that field, but the tombstone logic sits in a bit of a minefield of weird artifacts ported from k/k. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/priority awaiting-more-evidence |
@vincepri: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@seh Were you able to get more information from k/k? |
No, sorry, I didn't find anything telling when I last looked into it. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Does this field actually do anything? I have also noticed that it doesn't seem to populate |
The
event.DeleteEvent
type has a field called "DeleteStateUnknown," documented as follows:At present, this field is never written to, and nothing in the controller-runtime library reads it either. This field entered the source back in #2, on 7 June 2018, copying the code from the kubernetes-sigs/kubebuilder project.
Per discussion in the "kubebuilder" channel in the "Kubernetes" Slack team, @pwittrock suggested that perhaps we should use this field, writing to it when appropriate, rather than removing it from the library, which would require a major version change to avoid breaking current
Predicate
s.Not being sure of the original intention for this field, it looks like the
source/internal.EventHandler.OnDelete
method might be a fitting place, to indicate that we found acache.DeleteFinalStateUnknown
object in the cache, indicating that we missed a deleting watch event and might therefore have only a stale object available.For
Reconciler
s, if I understand the contract correctly, the distinction seems immaterial, as by the time they would go to inspect the object, it would be gone anyway; only its name and possibly its containing namespace would be presented to theReconciler
. However, other event handlers—andPredicates
that precede them—would get a chance to see this tombstone object.Should we populate this field? If so, where and when? Does its documentation adequately explain its meaning?
The text was updated successfully, but these errors were encountered: