-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config.loadConfig Breaking Change introduced in 0.4.0 #748
Comments
Thanks so much for reporting this! I'll add it to the release notes. In the mean time, I think this is an unintended regression, and we might want to fix it (although I suspect this brings us in line with what cc @joelanford who authored that change. Out of curiosity, what are the cases where |
/kind bug |
@DirectXMan12: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
release notes updated |
Cheers for the speedy response!
|
Good catch @edwardecook! It seems like a quick fix could be to check if Thoughts @DirectXMan12? |
I'd lean towards detecting if |
As part of 840ac8a there was a switch for the fallback behaviour of
config.loadConfig
(when not specifying via flag, env var or internal config) from identifying the default home directory withos/user
to thek8s.io/client-go/util/homedir
package (called viaclientcmd.NewDefaultClientConfigLoadingRules()
).This has the effect of switching from grabbing the os home config to relying on the
HOME
env var to be set which is not always the case.This is not listed as a breaking change within the v0.4.0 release notes however it will effect anyone using the
GetConfig
orGetConfigOrDie
functions.Let me know if there are any other details needed!
Cheers
cc @gmrodgers
The text was updated successfully, but these errors were encountered: