The reflector metrics is empty.

[qibobo]

In client_go_adapter.go, restclient and reflector metrics are registered as the following:

func init() {
	registerClientMetrics()
	registerReflectorMetrics()
}

When I import this go package, there are restclient metrics, but there is no reflector metric.
I have checked the client-go repo and found seem no one calls metricsFactory.

My question is that does reflector enable by default or it need some extra steps to enble?

https://github.com/kubernetes/client-go/blob/f772958f8a2941ad60a4bf5fb13da0acee7b2d76/tools/cache/reflector_metrics.go#L77-L89

var metricsFactory = struct {
	metricsProvider MetricsProvider
	setProviders    sync.Once
}{
	metricsProvider: noopMetricsProvider{},
}

// SetReflectorMetricsProvider sets the metrics provider
func SetReflectorMetricsProvider(metricsProvider MetricsProvider) {
	metricsFactory.setProviders.Do(func() {
		metricsFactory.metricsProvider = metricsProvider
	})
}

[djzager]

I may be missing something. But as I see it, the registerReflectorMetrics() function is the one calling SetReflectorMetricsProvider of the cache pkg from controller-runtime. https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/metrics/client_go_adapter.go#L124-L135

Based on my reading of https://book.kubebuilder.io/reference/metrics.html I would think that you would get reflector metrics for free without having to take extra steps.

[vincepri]

/kind bug
/priority awaiting-more-evidence

[vincepri]

/help

needs a little bit of investigation

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

needs a little bit of investigation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[charith-elastic]

Could it be because reflector metrics have been removed from Kubernetes: kubernetes/kubernetes#74636

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.