Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fakeclient should reject create|update without meta.name #838

Closed
djzager opened this issue Mar 5, 2020 · 3 comments · Fixed by #886
Closed

fakeclient should reject create|update without meta.name #838

djzager opened this issue Mar 5, 2020 · 3 comments · Fixed by #886
Assignees
@djzager
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone
v0.6.x

Comments

@djzager
Copy link
Contributor

djzager commented Mar 5, 2020

Re: #832 (comment)

Adding some of the basic validation you would find in other clients (ie. client-go) would be nice to have.
@djzager
Copy link
Contributor Author

djzager commented Mar 6, 2020

/assign

@vincepri vincepri added this to the v0.6.0 milestone Mar 26, 2020
@vincepri
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 26, 2020
@GrigoriyMikhalkin GrigoriyMikhalkin mentioned this issue Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djzager djzager

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging a pull request may close this issue.

⚠️ Fakeclient: reject create/update if Name isn't provided GrigoriyMikhalkin/controller-runtime
3 participants
@djzager @vincepri @k8s-ci-robot