Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for leader election #93

Closed
calind opened this issue Jul 26, 2018 · 3 comments
Closed

Support for leader election #93

calind opened this issue Jul 26, 2018 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@calind
Copy link
Contributor

calind commented Jul 26, 2018

Currently the manager won't do any kind of leader election. I think that the manager should implement of it so that you can run highly available controllers.

@DirectXMan12
Copy link
Contributor

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 27, 2018
@JoelSpeed
Copy link
Contributor

Does anyone know of any work already done on this? If not I'm going to look into this and try to raise a PR.

The first question I have about this is that the leader election will need a unique name per kubebuilder project. I assume this will have to come from a flag unless there is a unique identifier already, any ideas?

@zhujl1991
Copy link

@JoelSpeed When leader election is enabled, after I delete the deployment of my controller manager, the configmap won't be deleted automatically.

DirectXMan12 pushed a commit that referenced this issue Jan 31, 2020
added script to perform a quick test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants