-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default health check not working #965
Comments
Actually with the default endpoint name |
It's default check IN handler, not default handler. So it will work if you create handler without any custom checks. Controller, by default, doesn't create empty handlers. Regarding second comment. I think it would be ok to add trailing slash to default endpoints and add wrapper for mux that would remove trailing slash. |
@GrigoriyMikhalkin How to create health check handler without any custom checks? |
Ah, you can't do that for provided manager implementation. Beckause handler is created when you add check via |
/milestone Next This needs some investigation, I'm not too familiar with this part of the codebase. |
@vincepri: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@lazybetrayer Looks like solution to this problem was already merged d6fcdd6 |
/close |
@lazybetrayer: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
if no
AddHealthzCheck
is calledcm.readyzHandler
is nil, the health check endpoint will not be added.controller-runtime/pkg/manager/internal.go
Lines 415 to 417 in a457e27
But according to
controller-runtime/pkg/healthz/healthz.go
Lines 153 to 156 in a457e27
there should be a default check.
The text was updated successfully, but these errors were encountered: