default health check not working

[lazybetrayer]

if no AddHealthzCheck is called cm.readyzHandler is nil, the health check endpoint will not be added.

controller-runtime/pkg/manager/internal.go

Lines 415 to 417 in a457e27

	if cm.healthzHandler != nil {
	mux.Handle(cm.livenessEndpointName, http.StripPrefix(cm.livenessEndpointName, cm.healthzHandler))
	}

But according to

controller-runtime/pkg/healthz/healthz.go

Lines 153 to 156 in a457e27

	if len(h.Checks) == 0 && reqPath[1:] == "ping" {
	CheckHandler{Checker: Ping}.ServeHTTP(resp, req)
	return
	}

there should be a default check.

[lazybetrayer]

Actually with the default endpoint name /healthz, only the exact match is handled, paths like /healthz/ping is never handled.

[GrigoriyMikhalkin]

It's default check IN handler, not default handler. So it will work if you create handler without any custom checks. Controller, by default, doesn't create empty handlers.

Regarding second comment. I think it would be ok to add trailing slash to default endpoints and add wrapper for mux that would remove trailing slash.

[lazybetrayer]

@GrigoriyMikhalkin How to create health check handler without any custom checks?

[GrigoriyMikhalkin]

Ah, you can't do that for provided manager implementation. Beckause handler is created when you add check via Add...Check methods. But, i guess, that's not that big of a issue, to address it. If you only need ping check, you can just add it manually, like m.Add...Check("ping", healthz.Ping).

[vincepri]

/milestone Next
/help

This needs some investigation, I'm not too familiar with this part of the codebase.

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone Next
/help

This needs some investigation, I'm not too familiar with this part of the codebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[lazybetrayer]

/remove-lifecycle stale

[GrigoriyMikhalkin]

@lazybetrayer Looks like solution to this problem was already merged d6fcdd6

[lazybetrayer]

/close

[k8s-ci-robot]

@lazybetrayer: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.