Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta linters to travis. #10

Merged
merged 1 commit into from
Jun 9, 2018

Conversation

fanzhangio
Copy link

@fanzhangio fanzhangio commented Jun 8, 2018

#8

Added metalinter to travis.

TODO:

  • fix issues in codebase based on linters

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2018
@fanzhangio fanzhangio changed the title Add meta linters to travis. (WIP) Add meta linters to travis. Jun 8, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2018
@fanzhangio fanzhangio changed the title (WIP) Add meta linters to travis. Add meta linters to travis. Jun 8, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2018
@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2018
@pwittrock
Copy link
Contributor

/approve

@pwittrock pwittrock added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9eef00b into kubernetes-sigs:master Jun 9, 2018
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
ncdc added a commit to ncdc/controller-runtime that referenced this pull request May 31, 2022
Add Indexer plumbing, add kcp indexers by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants