-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Remove deprecated "--master" flag #1039
⚠️ Remove deprecated "--master" flag #1039
Conversation
/hold Holding until we open the main branch to v0.7 |
Thank you for doing this! |
/wg naming |
/milestone v0.7.x |
After I removed apiServerURL, what is the cause of this error? |
/test pull-controller-runtime-test-master |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tanjunchen, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle |
Fixes:#1028
/cc @vincepri