Clarify use of Scheme #105
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pmorie If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
| // Reconciler reconciles an object | ||
| Reconciler reconcile.Reconciler | ||
| // Reconcile is the reconciler for the type the controller manages. | ||
| Reconcile reconcile.Reconcile |
There was a problem hiding this comment.
Comment improvement is fine but questions about code change. Do we even have Reconcile interface ? I thought the interface is Reconciler ?
There was a problem hiding this comment.
we used to have one, but I think it got renamed really early to Reconciler.
|
I think that's a bad merge - I'll fix it.
…On Tue, Aug 7, 2018 at 1:22 PM, Sunil Arora ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/controller/controller.go
<#105 (comment)>
:
> @@ -33,8 +33,8 @@ type Options struct {
// MaxConcurrentReconciles is the maximum number of concurrent Reconciles which can be run. Defaults to 1.
MaxConcurrentReconciles int
- // Reconciler reconciles an object
- Reconciler reconcile.Reconciler
+ // Reconcile is the reconciler for the type the controller manages.
+ Reconcile reconcile.Reconcile
Comment improvement is fine but questions about code change. Do we even
have Reconcile interface ? I thought the interface is Reconciler ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#105 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmJDqv-aq7Qs53k3FTF5j2tkXSDYVks5uOczDgaJpZM4Vycr2>
.
|
| // Reconciler reconciles an object | ||
| Reconciler reconcile.Reconciler | ||
| // Reconcile is the reconciler for the type the controller manages. | ||
| Reconcile reconcile.Reconcile |
There was a problem hiding this comment.
we used to have one, but I think it got renamed really early to Reconciler.
|
I haven't meant to let this rot - last couple weeks have been crazy for me. Will fix shortly. |
|
@pmorie Still working on this? @DirectXMan12 Maybe we can just fix it up directly through the GH UI and merge it? |
|
This PR --> #295 improved the docs. So closing this in favor of this. |
Cleanup kubebuilder book language
Attempts to clarify the use of
Scheme, plus other miscellaneous godoc improvements.