Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Generate junit in CI #1053

Merged
merged 1 commit into from
Aug 3, 2020
Merged

🏃 Generate junit in CI #1053

merged 1 commit into from
Aug 3, 2020

Conversation

alvaroaleman
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2020
@alvaroaleman
Copy link
Member Author

/hold
This makes a test run with failing tests pass https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_controller-runtime/1053/pull-controller-runtime-test-master/1284892162755923969 ?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2020
@alvaroaleman
Copy link
Member Author

/retest

@alvaroaleman alvaroaleman mentioned this pull request Jul 21, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2020
@alvaroaleman
Copy link
Member Author

@vincepri I've updated the test script to check in CI if the junit xmls have failures as a workaround to the ginkgo not properly failing on failures ¯_(ツ)_/¯

@vincepri
Copy link
Member

vincepri commented Aug 1, 2020

Any reason we're skipping 30 tests?

@vincepri
Copy link
Member

vincepri commented Aug 1, 2020

Looking at the code, I see the warning on the reporter, I'm hoping that folks don't use this blindly :/

@alvaroaleman
Copy link
Member Author

Any reason we're skipping 30 tests?

No idea but not because of this PR, we just see that now which I guess is a good thing.

Looking at the code, I see the warning on the reporter, I'm hoping that folks don't use this blindly :/

Yeah, me too 😬

@alvaroaleman
Copy link
Member Author

@vincepri are you comfortable with how the change looks like currently?

My subjective impression is that our tests are still flaking quite a bit and it would be great if we could use testgrid to see which tests exactly are flaking how much rather than just seeing "some runs pass, some fail"

@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

Yeah that makes sense, let's get this merged!

/lgtm

@vincepri
Copy link
Member

vincepri commented Aug 3, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@vincepri vincepri added this to the v0.6.x milestone Aug 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit de782a3 into kubernetes-sigs:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerred gerred Awaiting requested review from gerred

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alvaroaleman @k8s-ci-robot @vincepri