-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Add support to read webhook configurations from files for WebhookInstallOptions #1080
⚠️ Add support to read webhook configurations from files for WebhookInstallOptions #1080
Conversation
Hi @jiachengxu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
DirectoryPaths []string | ||
// Paths is a list of paths to the directories or files containing the mutating or validating webhooks yaml or json configs. | ||
Paths []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renaming DirectoryPaths
to Paths
would be a breaking change right?
If so, we should probably mark this commit with a
Unless we want to avoid that and add a separate field e.g FilePaths
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you are right, it is a breaking change.
I prefer to not add FilePaths
since I would like to keep it consistent with CRDInstallOptions.
WDYT? @vincepri @DirectXMan12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for consistency, we can delay this change until v0.7
/milestone v0.7.x |
/ok-to-test |
/retest |
/test pull-controller-runtime-apidiff-master |
@jiachengxu: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alvaroaleman @vincepri How can I make the |
You can't, but having it pass is not mandatory for merges, its more of an informational thing. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, jiachengxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixes #1019
This PR adds support to read webhook configurations from files for
WebhookInstallOptions