Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move certprovisioner pkg #11

Merged
merged 1 commit into from
Jun 9, 2018

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jun 8, 2018

The certprovisioner pkg written by myself has been reviewed and merged into the kubebuilder repo.
This PR is moving the package to the controller-runtime repo.

Move
kubernetes-sigs/kubebuilder#243
and
kubernetes-sigs/kubebuilder#245

Preparation for migrating mengqiy/WebhookCertManager@89cdb84 to the controller v2 lib.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2018
@pwittrock
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2018
@pwittrock
Copy link
Contributor

/approve

@pwittrock pwittrock added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6f99e24 into kubernetes-sigs:master Jun 9, 2018
@mengqiy mengqiy deleted the certprovisioner branch June 11, 2018 16:13
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
Move admission package to internal until it is ready
fabianvf added a commit to fabianvf/controller-runtime that referenced this pull request Jun 10, 2022
UPSTREAM: <carry>: make pkg/envtest compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants