Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ admission responses with raw Status #1129

Merged
merged 7 commits into from
Aug 27, 2020
Merged

⚠️ admission responses with raw Status #1129

merged 7 commits into from
Aug 27, 2020

Commits on Aug 18, 2020

  1. ⚠️ admission responses with raw Status

    If a custom webhook validator returns a metav1.Status object as the error, the validation handler will build an admission response with this Status object as is, instead of building a new Status object based on err.Error()
    
    This might be considered as a breaking change since the behaviour of the
    validation handler is going to be slightly different from what the users
    might expect based on the previous version of the code
    Eric Abramov committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    1902414 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. ⚠️ admission responses with raw Status

    If a custom webhook validator returns a metav1.Status object as the error, the validation handler will build an admission response with this Status object as is, instead of building a new Status object based on err.Error()
    
    This might be considered as a breaking change since the behaviour of the
    validation handler is going to be slightly different from what the users
    might expect based on the previous version of the code
    Eric Abramov committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2c49665 View commit details
    Browse the repository at this point in the history
  2. ⚠️ admission responses with raw Status

    If a custom webhook validator returns a metav1.Status object as the error, the validation handler will build an admission response with this Status object as is, instead of building a new Status object based on err.Error()
    
    This might be considered as a breaking change since the behaviour of the
    validation handler is going to be slightly different from what the users
    might expect based on the previous version of the code
    Eric Abramov committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f61e953 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Adding tests for webhook/admission/validator.go

    Eric Abramov committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    1f5be8a View commit details
    Browse the repository at this point in the history
  2. Fix tests (undo FDescribe)

    Eric Abramov committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    a76edb0 View commit details
    Browse the repository at this point in the history
  3. Align test structure

    Eric Abramov committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    47eafd8 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Fix CR comments for tests

    Eric Abramov committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    9f235ae View commit details
    Browse the repository at this point in the history