Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Controller: Return error when started more than once #1139

Merged
merged 1 commit into from
Aug 26, 2020
Merged

🐛 Controller: Return error when started more than once #1139

merged 1 commit into from
Aug 26, 2020

Commits on Aug 25, 2020

  1. 🐛 Controller: Return error when started more than once 

    Starting the controller more than once is always wrong. Today, it will
result in:
* Its active workqueue being re-created, resulting in a data race,
  breaking the guarantee of "there is at most one worker on a given
  queue key" and messed-up metrics
* Starting double as many workers as configured

This PR changes that to instead return an error on all subsequent Start
attempts.
    @alvaroaleman
    alvaroaleman committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    db22614 View commit details
    Browse the repository at this point in the history