-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Make leader election resourcelock configurable #1147
✨ Make leader election resourcelock configurable #1147
Conversation
Welcome @timebertt! |
Hi @timebertt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pwittrock |
e39d473
to
bcd0d1d
Compare
bcd0d1d
to
dc13f52
Compare
dc13f52
to
e981692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @timebertt !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR makes the leader election resource lock configurable via
manager.Options.LeaderElectionResourceLock
.It can be set to one of the lock types supported by client-go (ref):
endpoints
configmaps
leases
endpointsleases
configmapsleases
It keeps the default of
configmapsleases
introduced by #1144, but allows folks to explicitly configure other LE strategies.Fixes #460
/assign @alvaroaleman